smlxl / evm.codes

Source for evm.codes an Ethereum Virtual Machine Opcodes Interactive Reference
https://evm.codes/
MIT License
727 stars 135 forks source link

Redundancy in calldata description #289

Closed shandysulen closed 7 months ago

shandysulen commented 10 months ago

In The calldata section of About the EVM, the paragraph begins with:

The calldata region is the data sent to a transaction as part of a smart contract transaction.

"sent to a transaction as part of a smart contract transaction" caught me off guard when I read it as it seems redundant and just wanted to double-check if it was intentional. Is it meant to be "sent to an address as part of a smart contract transaction"?

peroket commented 9 months ago

Thank you for your question :-)

I agree the formulation is not the best here. However, sending to an address has no particular meaning to me. An address is just a (big) number. The data only makes sense in the case of a transaction.

I guess we should just rewrite to "The calldata region is the data sent to a smart contract transaction". What do you think?

shandysulen commented 9 months ago

I'm a fan of the rewrite! I find it succint and more clear in its meaning :)