Contract Viewer

[vercel[bot]]

@hananbeer is attempting to deploy a commit to the smlXL Team on Vercel.

A member of the Team first needs to authorize it.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
evm-codes	❌ Failed (Inspect)			Apr 10, 2024 2:06am

[hananbeer]

lord why does this build on my machine but fails on vercel

haven't I suffered enough?

side note: running yarn lint -> eslint warns that:

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.5.0

YOUR TYPESCRIPT VERSION: 4.8.3

although the project is compiled with typescript@^5.0.4, it seems linting is done with this older version?

[charisra]

Note to reviewers: I created https://github.com/smlxl/evm.codes/pull/317 https://github.com/smlxl/evm.codes/pull/318 to take over from this branch. I took care of as much PR feedback as I could there, put comments where needed above to have context.

For the rest + new feedback let's continue on #317 #318

This can be closed soon.

[mcmxcdev]

Note to reviewers: I created #317 to take over from this branch. I took care of as much PR feedback as I could there, put comments where needed above to have context.

For the rest + new feedback let's continue on #317

This can be closed soon.

Why did you not just push commits into the fork? Now we have yet another PR opened

[charisra]

Note to reviewers: I created #317 #318 to take over from this branch. I took care of as much PR feedback as I could there, put comments where needed above to have context. For the rest + new feedback let's continue on #317 #318 This can be closed soon.

Why did you not just push commits into the fork? Now we have yet another PR opened

If you prefer a fork, feel free to take #317 #318 and use it here. I will keep my work on #317 #318 to have separation of concerns. More than one people are pushing here which makes an already confusing situation even more confusing for me.

[charisra]

Superseded by https://github.com/smlxl/evm.codes/pull/318