search

smmills / Phodymm

Photodynamics Code v1
2 stars 2 forks source link

phasefold.py phase width adjust by planet period #9

Closed dragozzine closed 5 years ago

dragozzine commented 5 years ago

Ran phasefold.py on a 4.8-day period planet and it choked because the "phasewidth" was hardcoded to 2.5. When changed to 1.5, it worked fine, so I think this should be dynamically set based on the period of the planet.

I apologize, by the way, for not fixing these myself and submitting a PR, but I'm rushing to get things out to my 227 students. Thanks, Darin

smmills commented 5 years ago

phasewidth is hard coded to 0.4 (and has never been changed). This allows it to work for any planets with orbital period >0.8 day -- although it can have unwanted behavior in the case of several short-period planets due to rejecting (almost) all transits due to nearly-overlapping times. If you found a different phasewidth value in phasefold.py, I suspect you may have changed it and forgotten.