search

smmr-software / privacy-redirect-safari

A Safari extension that redirects Twitter, YouTube, Reddit, and more to privacy friendly alternatives.
GNU General Public License v3.0
165 stars 14 forks source link

Custom instances: allow http protocol #30

Closed isker closed 2 years ago

isker commented 2 years ago

Hi. Thanks for this app.

I self host instances of various services that I’d like to redirect to. But these instances are exposed only over http, and the redirect assumes https. It is not possible to reach my instances: it seems that https is unconditionally prepended when redirecting.

(http is acceptable for me as my instances are not exposed to the internet and are reachable only via WireGuard tunneling, which provides the actual handshake/encryption.)

The upstream browser extension this project is forked from does not have this issue; I can configure http redirects there.

isker commented 2 years ago

I think it is fine to assume https if no protocol is given in the settings, but ideally whatever is handling that can parse the configured URL to become protocol aware so that other protocols (or at least http 🌞) can be configured.

isker commented 2 years ago

Ah, it seems from https://github.com/smmr-software/privacy-redirect-safari/search?q=https&type= that the protocol is not configured at all and each of the scripts just hard codes https. Welp, that makes this a bit more work…

FIGBERT commented 2 years ago

Done! Have fun with WireGuard!

isker commented 2 years ago

Thanks! Looking forward to the release.

isker commented 2 years ago

It works! Thanks!