call hls.destroy() in hlsjs-plyr-driver

smnbbrv / ngx-plyr

Angular 6+ binding for Plyr video & audio player

https://smnbbrv.github.io/ngx-plyr/

MIT License

100 stars 65 forks source link

Closed gbeane closed 4 years ago

gbeane commented 4 years ago

I've been using ngx-plyr to play HLS video using the example hls driver.

When I destroy the Angular component that my ngx-plyr is in, I see in the network activity my app continues to load the .m3u8 file periodically.

this change seems to have fixed the problem for me.

smnbbrv commented 4 years ago

Hi @gbeane

thank you for the PR!

Could you please change commit name to the semantic-release notation? E.g. add docs: prefix to your current one:

docs: call hls.destroy() in hlsjs-plyr-driver

gbeane commented 4 years ago

added docs: prefix to commit message