search

smnbbrv / ngx-plyr

Angular 6+ binding for Plyr video & audio player
https://smnbbrv.github.io/ngx-plyr/
MIT License
100 stars 65 forks source link

Update plyr and use their own type definitions #35

Closed eiennohi closed 4 years ago

eiennohi commented 4 years ago

Summary

closes https://github.com/smnbbrv/ngx-plyr/issues/31

smnbbrv commented 4 years ago

Hi @eiennohi

love this PR. Thank you very much for your work!

This is a breaking change (although current version is not working :D), so the new major version should be triggered by semantic-release - I'm fine with that, just the commit should receive the corresponding message, so to say smth like

(feat): update plyr and use their own type definitions

BREAKING CHANGE: plyr types are not served anymore, plyr default export is not available anymore

Could you please include a similar message body (you can of course change the wording, it's just an example)?

smnbbrv commented 4 years ago

OK, since the PR is stale, I applied these changes. The build should be fixed though.

smnbbrv commented 4 years ago

Please use v4.0.0