search

smnorris / bcfishobs

Reference BC Known Fish Observations to the Freshwater Atlas stream network
Apache License 2.0
6 stars 2 forks source link

fish_observation_point_id is unstable #28

Closed smnorris closed 2 years ago

smnorris commented 2 years ago

It seems the IDs can change over time (as with FISS Obstacles).

There is not much we can do about this but it is worth noting in the README.

smnorris commented 2 years ago

Even if one considers all provided (and non-internally generated) columns in the source table, the data can have duplicates. This script should probably sift through the data to generate unique records and not bother storing the observation_id value in the output tables.

Example duplicate:

https://openmaps.gov.bc.ca/geo/pub/wfs?service=WFS&version=2.0.0&request=GetFeature&typeName=WHSE_FISH.FISS_FISH_OBSRVTN_PNT_SP&outputFormat=json&SRSNAME=epsg%3A4326&CQL_FILTER=SOURCE%3D%27FDIS+Database%3A+fshclctn_id+65162%27+and+SPECIES_CODE%3D%27CO%27+and+POINT_TYPE_CODE%3D%27Observation%27

smnorris commented 2 years ago

I think noting the id instability in the README is fine, no need to strip out the id values from the output products. The instability makes it harder to refer back to the source data but is not particularly important for other uses.