smnorris / bcfishpass

Model and monitor aquatic habitat connectivity in BC. Tools to plan and prioritize the assessment and remediation of barriers.
https://smnorris.github.io/bcfishpass
Apache License 2.0
8 stars 13 forks source link

data precision for cancelling natural barriers #518

Closed smnorris closed 2 months ago

smnorris commented 3 months ago

Spotted by @matthewcooper11

PK spawning is noted to occur on blue_line_key=360857270 to measure of 278m. CABD falls 4fbf92fd-f3b7-485b-834d-263a3dfb6139 gets snapped to the same stream at 276.8m - and is thus discarded from natural barriers because of the known spawning upstream.

Tweak the natural barrier load to only discard barriers below observed habitat if there is greater than x metres of habitat upstream. Because precision of various inputs varies I'm not sure where to set the cutoff, probably somewhere around 10-25m.

smnorris commented 3 months ago

Only salmon and steelhead habitat have this effect at this point: https://github.com/smnorris/bcfishpass/blob/main/model/01_access/sql/model_access_ch_cm_co_pk_sk.sql#L132 https://github.com/smnorris/bcfishpass/blob/main/model/01_access/sql/model_access_st.sql#L118

We do have some data for known WCT spawning - that query should be also be updated to cancel barriers downstream of observed habitat. https://github.com/smnorris/bcfishpass/blob/main/model/01_access/sql/model_access_wct.sql#L113

smnorris commented 3 months ago

Precision issue fixed. Cancelling WCT barriers below known spawning seems like a good idea but should be referred to modelling team, moving to separate issue.