search

smnorris / bcfishpass

Model and monitor aquatic habitat connectivity in BC. Tools to plan and prioritize the assessment and remediation of barriers.
https://smnorris.github.io/bcfishpass
Apache License 2.0
8 stars 13 forks source link

BOWR/QUES assessment data updates #533

Closed matthewcooper11 closed 4 months ago

matthewcooper11 commented 4 months ago

BOWR/QUES data updates. I also tried syncing my fork with the main bcfishpass as per Simon's previous comments on changes I have pushed.

smnorris commented 4 months ago

Not sure why the test build fails, I've opened a separate issue and will look in to that. There are a bunch of issues with the PR that are just related to file syncing. It might be easiest for me to work through them but I'll point them out.

nickw-CWF commented 4 months ago

What is the source for "Field Assessments"? Are these taken from PSCIS? And if from PSCIS, why is there info for the crossing but no assessment? Or is this some other field source? Where there is a source available, we should provide a link and/or citation.

These are from field assessments that a partner did, but there was no crossing or stream at the site so there was no PSCIS submission. We don't have a formal report to cite, but we could add the group that did the assessments (in this case Lhtako Dene). Would that work?

Not sure why the test build fails, I've opened a separate issue and will look in to that. There are a bunch of issues with the PR that are just related to file syncing. It might be easiest for me to work through them but I'll point them out.

Just to make sure we're on the same page, will you resolve the technical issues for this PR or do you want @matthewcooper11 do create a fresh clone and try to submit again (he can add detail to the source field as well)?

smnorris commented 4 months ago

What is the source for "Field Assessments"? Are these taken from PSCIS? And if from PSCIS, why is there info for the crossing but no assessment? Or is this some other field source? Where there is a source available, we should provide a link and/or citation.

These are from field assessments that a partner did, but there was no crossing or stream at the site so there was no PSCIS submission. We don't have a formal report to cite, but we could add the group that did the assessments (in this case Lhtako Dene). Would that work?

That would be perfect.

Not sure why the test build fails, I've opened a separate issue and will look in to that. There are a bunch of issues with the PR that are just related to file syncing. It might be easiest for me to work through them but I'll point them out.

Just to make sure we're on the same page, will you resolve the technical issues for this PR or do you want @matthewcooper11 do create a fresh clone and try to submit again (he can add detail to the source field as well)?

Either is fine but if @matthewcooper11 can add the details and create a fresh PR that is easiest.