Mocks are unsafe in concurrent calls

mock.State.TimesCount property is being modified without any synchronization in these two places:

This can result in some updates being lost, here is the test to verify it (it consistently fails on my machine):

package handlers_test

import (
    "io"
    "net/http"
    "sync"
    "testing"
    "time"

    "github.com/Thiht/smocker/server"
    "github.com/Thiht/smocker/server/config"
    "github.com/Thiht/smocker/server/types"
    "github.com/stretchr/testify/assert"
    "github.com/stretchr/testify/require"
)

func TestMocks_GenericHandler(t *testing.T) {
    server, mocks := server.NewMockServer(config.Config{
        LogLevel:             "panic",
        ConfigListenPort:     8081,
        ConfigBasePath:       "/",
        MockServerListenPort: 8080,
        StaticFiles:          ".",
        Build: config.Build{
            AppName:      "smocker",
            BuildVersion: "dev",
            BuildDate:    time.Now().String(),
        },
    })
    session := mocks.NewSession("test")
    _, err := mocks.AddMock(session.ID, &types.Mock{
        Request: types.MockRequest{
            Method: types.StringMatcher{Matcher: "ShouldMatch", Value: "GET"},
            Path:   types.StringMatcher{Matcher: "ShouldMatch", Value: "/api/v1"},
        },
        Response: &types.MockResponse{
            Status: 200,
            Body:   "test",
        },
        Context: &types.MockContext{
            Times: 60000,
        },
    })
    require.NoError(t, err)

    go func() {
        if err := server.ListenAndServe(); err != http.ErrServerClosed {
            t.Fatal(err)
        }
    }()

    wg := &sync.WaitGroup{}
    wg.Add(20)
    for i := 0; i < 20; i++ {
        go func() {
            defer wg.Done()
            for j := 0; j < 3000; j++ {
                resp, err := http.Get("http://localhost:8080/api/v1")
                require.NoError(t, err)

                body, err := io.ReadAll(resp.Body)
                require.NoError(t, err)

                assert.Equal(t, 200, resp.StatusCode)
                assert.Equal(t, "test", string(body))
            }
        }()
    }

    wg.Wait()

    assert.Equal(t, 60000, session.Clone().Mocks.Clone()[0].State.TimesCount)
}

It could be easily fixed by replacing TimesCount int type with something like atomic.Uint64. Required patch:

https://github.com/SuddenGunter/smocker/commit/756697914179dd99c16df6e7330f3bcb3214687f

Now the test doesn't fail.

I could prepare a PR with these changes, the problem is: some dependencies (like linter) are a bit out of date and would need to be updated. Without it - CI would just fail, it fails without any of my changes on raw fork of Thiht/smocker master branch, see https://github.com/SuddenGunter/smocker/actions/runs/4519253233.

If you ok with me preparing a PR with this fix + some dependencies being updated - please let me know

smocker-dev / smocker

Mocks are unsafe in concurrent calls #272