smogon / damage-calc

Pokemon games damage calculator
https://calc.pokemonshowdown.com
MIT License
391 stars 367 forks source link

The damage calc does not match what is on Pokemon Showdown #291

Closed NotHadakUra closed 5 years ago

NotHadakUra commented 5 years ago

Using the damage calc here: https://pokemonshowdown.com/damagecalc/

252 SpA Choice Specs Tapu Koko Grass Knot (120 BP) vs. 252 HP / 252+ SpD Groudon-Primal: 244-288 (60.3 - 71.2%) -- guaranteed 2HKO

252 SpA Choice Specs Tapu Koko Grass Knot (120 BP) vs. 252 HP / 252+ SpD Groudon: 244-288 (60.3 - 71.2%) -- guaranteed 2HKO

Note they are the same percentages for both Primal-Groudon and normal Groudon

Here is a replay showing this situation in an AG game during the first 2 turns: https://replay.pokemonshowdown.com/gen7anythinggoes-878492172

Here is a replay of the testing I did after: https://replay.pokemonshowdown.com/gen7anythinggoes-878501709

You can see that the damage is not the same at all. The damage calc is bugged.

Interestingly by selecting a non Primal Groudon set and modifying it you can see the calc display Groudon-Primal (even though this should be a calc for a normal groudon) and give the correct damage calculation.

groudon testing

Zarel commented 5 years ago

This is not the repository for the damage calculator. You're looking for: https://github.com/Zarel/honko-damagecalc

Zarel commented 5 years ago

Oh hey I forgot, GitHub has a Transfer Issue button now! It seems to have worked.

AustinXII commented 5 years ago

Hmm there appears to be an issue with what forme is automatically selected when selecting a pokemon with an alternate forme, will investigate. I imagine #281 is at fault

AustinXII commented 5 years ago

Also that is pretty cool, github is adding a lot of cool features recently