smogon / damage-calc

Pokemon games damage calculator
https://calc.pokemonshowdown.com
MIT License
396 stars 366 forks source link

Support Super Fang & Ruination #576

Open ForwardFeed opened 1 year ago

ForwardFeed commented 1 year ago

And i've paid attention to round down if the HP are odd

shrianshChari commented 1 year ago

Nature's Madness seems to already be implemented, but you should also have this apply to Ruination as well because that move works the same way as Super Fang and Nature's Madness.

Additionally, Super Fang can hit Ghost types in Gen 1, so make sure that also gets implemented.

ForwardFeed commented 1 year ago

I'll work on it

ForwardFeed commented 1 year ago

Also two question, why aren't the genders fully implemented, i mean is there a specific reason for that? Also i plan to integrate Psywave & Magnitude, but i have no clue how to format the data, should i just show "Lowest BP Roll - Median BP roll - highest BP Roll ", or do like with multi-hits move where there is a menu on the BP rolls and the damage shows normally from there? thanks

thejetou commented 1 year ago

Also two question, why aren't the genders fully implemented, i mean is there a specific reason for that? Also i plan to integrate Psywave & Magnitude, but i have no clue how to format the data, should i just show "Lowest BP Roll - Median BP roll - highest BP Roll ", or do like with multi-hits move where there is a menu on the BP rolls and the damage shows normally from there? thanks

I'm not sure why the genders aren't full implemented either honestly, lol.

About Psywave & Magnitude, probably just format it "Lowest roll - Highest roll" and include each possible roll? I think that's sufficient.

ForwardFeed commented 1 year ago

Also for the gender, i was thinking more about the addSets and ExportPokemon in the front end. Rivalry and gender in the UI is well implemented, my bad i missexplained. Also i slided a fix for something that has nothing to do about Halving HP moves, i have a doubt about if this is wrong.