search

smogon / damage-calc

Pokemon games damage calculator
https://calc.pokemonshowdown.com
MIT License
396 stars 366 forks source link

Support Sharing calculation #587

Open ForwardFeed opened 1 year ago

ForwardFeed commented 1 year ago

in reference to #499 I haven't fully tested it however as I don't know too much how should I test it. in todofix there is this bug with Dynamax and non-full HP situation.

AustinXII commented 5 months ago

@thejetou opinions? I'm sure a lot of people would like this feature.

AustinXII commented 4 months ago

After some testing, it does seem to works for abomasnow but fails to work if you try sharing a calc with a different pokemon. I'll see if I can figure out whats going on and hopefully we can merge this.

AustinXII commented 4 months ago

Oh I see, it only doesn't work if the Pokémon has more than one form

AustinXII commented 4 months ago

Also the set should only be shown in the same generation the damage calc was made in. Currently if you shared a damage calc and the person uses the link, that set would be shown in all generations.

ForwardFeed commented 4 months ago

When I did the code a while back ago it was supposed to redirect the receiver gen to the sender gen. this PR is likely not up to date of the current codebase on many points.

AustinXII commented 4 months ago

@ForwardFeed I would love to add this if you’d take a jab at updating this PR now that I’m back.

ForwardFeed commented 4 months ago

I'm sorry I'll probably not work on the smogon calc in the future. I've made this PR 9 months ago, In between I have made my own fork where i changed a lot of code that i don't remember well the codebase of the smogon calc and currently If I'm again working on a calc I would want to make my own nuzlocke specialized calc would I have time and value for that.

AustinXII commented 4 months ago

@ForwardFeed no problem at all. We appreciate the PR, I’m sorry for the ghosting and no response.