Improve multihit move support

smogon / damage-calc

Pokemon games damage calculator

https://calc.pokemonshowdown.com

MIT License

387 stars 365 forks source link

Improve multihit move support #590

Closed ShivaD173 closed 7 months ago

ShivaD173 commented 9 months ago

Combine TimesUsed and Multihit to use the same between move function previously used by parental bond
New/Fixed Effects
- Stamina (fixed)
- Weak Armor (fixed)
- Luminous Moss
- Kee/Maranga Berry
- Water Compaction
- Mummy/Wandering Spirit/Lingering Aroma
- Seed Sower
- Sand Spit

thejetou commented 8 months ago

This implementation should also accordingly be in the other mechanics/ files as needed.

Also, can you write unit tests? Multihit code is pretty finicky in the Honko engine so having unit tests would be great for sanity sake.

ShivaD173 commented 8 months ago

Updated gen3-9 mechanics files for multihit/multiturn accuracy Modularized code similar to gen789 file to make it easier to do this. Fixed a few more bugs with displaying abilities, especially with niche items/abilities. Created tests for multi-hit interactions.

ShivaD173 commented 7 months ago

Fixed the critical hit problem. Fixed the hit input in gen56, and added a test for Multiscale Changed the Tera stellar interaction with multihit moves.

thejetou commented 7 months ago

Great work. Thank you!