DLC 2 Support for calculator

smogon / damage-calc

Pokemon games damage calculator

https://calc.pokemonshowdown.com

MIT License

397 stars 367 forks source link

DLC 2 Support for calculator #591

Closed ShivaD173 closed 11 months ago

ShivaD173 commented 11 months ago

Still Waiting for Dex to pass tests, but keeping PR ready
Added all new pokemon, moves, and abilities
Added Mechanics for new moves and abilites
Added support for Terestal Tera Type, right now always assumes boost. Let me know if better way to do it.

thejetou commented 11 months ago

Still Waiting for Dex to pass tests, but keeping PR ready

@pkmn/dex has been update with DLC2 as of a few hours ago.

thejetou commented 11 months ago

Doesn't your implementation mean that Stellar Pokemon are neutral to everything defensively?

ShivaD173 commented 11 months ago

Fixed these bugs listed, thanks for the review. Tests now pass, versions updated to 0.8.1 for the dex and the other @pkmn packages. Still need to have some way to define whether each type is tera boosted (probably some checkmark somewhere?), but I leave that to someone else.

thejetou commented 11 months ago

Still need to have some way to define whether each type is tera boosted (probably some checkmark somewhere?), but I leave that to someone else.

I'll work on that right now and when I'm done I'll merge your PR and push my commit.

Hopefully we can finish this today :).

thejetou commented 11 months ago

Great work, thank you!