Gens 4-9: Remove interaction between Natural Gift and Berry Juice/Berry Sweet

[shrianshChari]

Currently, when a Pokemon uses Natural Gift while holding a Berry Juice, it is treated as a 1 BP Normal-type move. This will now accurately display that a Pokemon using Natural Gift while holding a Berry Juice will deal 0 damage.

[shrianshChari]

Bumping.

[ShivaD173]

This fails to take into account Berry Sweet, which also has the same wrong interaction. An easier approach than this I think would be to just change items.ts:400 from 1 to 0bp.

[shrianshChari]

An easier approach than this I think would be to just change items.ts:400 from 1 to 0bp.

The reason why I didn't want to do this was that the text that would display would be inconsistent with other items that don't interact with Natural Gift. Take an Abomasnow holding an Icy Rock:

Abomasnow Natural Gift vs. 168 HP Abomasnow: 0-0 (0 - 0%) -- possibly the worst move ever

To highlight that Berry Juice and Berry Sweet don't interact at all with Natural Gift, we want to ensure the text isn't different so that it isn't confusing to people who are familiar with how Natural Gift appears when using a berry.

This is what it would look like when changing the bp from 1 to 0:

Berry Juice Abomasnow Natural Gift (Normal) vs. 168 HP Abomasnow: 0-0 (0 - 0%) -- possibly the worst move ever

And this is what it would look like when explicitly telling Natural Gift to ignore Berry Juice and Berry Sweet:

Abomasnow Natural Gift vs. 168 HP Abomasnow: 0-0 (0 - 0%) -- possibly the worst move ever

As you can see, the second example is more in line with how Natural Gift interacts with other items, and I believe it is preferable to treat Berry Juice and Berry Sweet this way.

[thejetou]

Thanks!