smogon / pokemon-showdown-client

The client for Pokémon Showdown

http://pokemonshowdown.com

GNU Affero General Public License v3.0

565 stars 792 forks source link

/hidejoins and /showjoins rewrite #1348

Open thejetou opened 5 years ago

thejetou commented 5 years ago

The server will always send join / leave messages
/hidejoins and /showjoins will hide and show joins / leave messages in the current room, respectively
/hidejoins battles and /showjoins battles will hide and show joins / leave messages in all battle rooms, respectively
/hidejoins chatrooms and /showjoins chatrooms will hide and show joins / leave messages in all chatrooms, respectively

The default state of hiding join / leave messages won't change, battles will show them, while chatrooms won't.

Zarel commented 5 years ago

The server will always send join / leave messages

It already does though.

Zarel commented 5 years ago

I don't mind this change, but I think the default auto-messages could stand to be a bit smarter. I've always thought about "auto-off when usercount goes above 6" or something like that.

thejetou commented 5 years ago

It already does though.

Yeah, I wasn't aware it just sent it as |j|, which I guess implies it as more "silent".

scheibo commented 5 years ago

|J| is the silent one (I made this mistake as well)

thejetou commented 5 years ago

1352 is a phase one of sorts. I still want to eventually do:

Add a /force(show|hide)joins in the future, which would show all joins / leave messages
Add a "Show Joins / leave messages" option to replays
Make the auto-messages smarter as @Zarel said.

Zarel commented 5 years ago

I don't think there needs to be a /forcehidejoins. I'm fine with just changing how /hidejoins works, and adding an /autoshowjoins.

(I also don't know what /forceshowjoins would do, but I assume you just didn't think about it when you typed that.)

thejetou commented 5 years ago

(I also don't know what /forceshowjoins would do, but I assume you just didn't think about it when you typed that.)

It would just show |J| (silent) messages in the logs.

Zarel commented 5 years ago

It would just show |J| (silent) messages in the logs.

That's what /showjoins does. I'm saying I don't know what /forceshowjoins would do differently.

thejetou commented 5 years ago

I don't think there needs to be a /forcehidejoins. I'm fine with just changing how /hidejoins works, and adding an /autoshowjoins.

Either works for me.

That's what /showjoins does. I'm saying I don't know what /forceshowjoins would do differently.

Ooh, I wasn't aware that was the case.

Zarel commented 5 years ago

...What did you think /showjoins did?