smogon / pokemon-showdown-client

The client for Pokémon Showdown
http://pokemonshowdown.com
GNU Affero General Public License v3.0
560 stars 786 forks source link

Babel 7.17.10 breaks build #1968

Closed Parnassius closed 2 years ago

Parnassius commented 2 years ago

Babel recently removed their dependency on source-map (see https://github.com/babel/babel/pull/14497), which is used in the build script. This is the output of ./build full in a freshly cloned repo:

``` Installing dependencies... npm WARN deprecated mkdirp@0.5.4: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.) npm WARN deprecated debug@3.2.6: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797) added 391 packages, and audited 392 packages in 19s 42 packages are looking for funding run `npm fund` for details 6 high severity vulnerabilities To address all issues (including breaking changes), run: npm audit fix --force Run `npm audit` for details. config.js does not exist. Creating one with default settings... Cloning into 'pokemon-showdown'... Syncing data from Git repository... npm WARN deprecated har-validator@5.1.5: this library is no longer supported npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142 npm WARN deprecated node-pre-gyp@0.11.0: Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future DONE Loading gen 6 data... DONE Building `data/search-index.js`... (WARNING: NO ARTICLES) DONE Building `data/teambuilder-tables.js`... DONE Building `data/pokedex.js`... DONE Building `data/moves,items,abilities,typechart,learnsets.js`...DONE Updating file `data/learnsets-g6`... DONE Updating animated sprite dimensions... SKIPPED node:internal/modules/cjs/loader:936 throw err; ^ Error: Cannot find module 'source-map' Require stack: - /tmp/pokemon-showdown-client/build-tools/compiler.js - /tmp/pokemon-showdown-client/build-tools/update at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15) at Function.Module._load (node:internal/modules/cjs/loader:778:27) at Module.require (node:internal/modules/cjs/loader:999:19) at require (node:internal/modules/cjs/helpers:102:18) at Object. (/tmp/pokemon-showdown-client/build-tools/compiler.js:16:19) at Module._compile (node:internal/modules/cjs/loader:1099:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10) at Module.load (node:internal/modules/cjs/loader:975:32) at Function.Module._load (node:internal/modules/cjs/loader:822:12) at Module.require (node:internal/modules/cjs/loader:999:19) { code: 'MODULE_NOT_FOUND', requireStack: [ '/tmp/pokemon-showdown-client/build-tools/compiler.js', '/tmp/pokemon-showdown-client/build-tools/update' ] } Node.js v17.7.1 node:child_process:902 throw err; ^ Error: Command failed: node ./build-tools/update full at checkExecSyncError (node:child_process:828:11) at execSync (node:child_process:899:15) at Object. (/tmp/pokemon-showdown-client/build:70:1) at Module._compile (node:internal/modules/cjs/loader:1099:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10) at Module.load (node:internal/modules/cjs/loader:975:32) at Function.Module._load (node:internal/modules/cjs/loader:822:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12) at node:internal/main/run_main_module:17:47 { status: 1, signal: null, output: [ null, null, null ], pid: 14347, stdout: null, stderr: null } Node.js v17.7.1 ```

Linux x64 (openSUSE Tumbleweed), Node 17.7.1, npm 8.5.2

aviettran commented 2 years ago

1970 created

Parnassius commented 2 years ago

Fixed by #1970