search

smogon / pokemon-showdown-client

The client for Pokémon Showdown
http://pokemonshowdown.com
GNU Affero General Public License v3.0
543 stars 758 forks source link

Improve detection of U-turn switch-outs #333

Open Slayer95 opened 9 years ago

Slayer95 commented 9 years ago

The heuristic of checking pokemon.lastMove is -in addition to hacky- wrong, as a pokémon can in fact switch-out by "normal methods" after using U-turn and triggering foe's Eject Button. Replay showing false positive for U-turn : http://replay.pokemonshowdown.com/ou-209269750

To fix this, the message displayed on switch-out POKEMON went back to PLAYER! should rely on a server message.

Other issues relevant to switching protocol: Zarel/Pokemon-Showdown-Client#314 https://github.com/Zarel/Pokemon-Showdown/issues/1452

Zarel commented 6 years ago

It's funny, we never got around to fixing this.

Zarel commented 6 years ago

I'm surprised we still aren't sending a server message.