search

smogon / pokemon-showdown-loginserver

MIT License
4 stars 26 forks source link

CORS issues on new login server? #13

Closed kumarde closed 1 year ago

kumarde commented 1 year ago

Hi there,

Not sure if this is the right avenue for this particular issue, so please let me know if there's another channel to go through.

I know a new version of the login server was deployed over the weekend per play.pokemonshowdown.com. Since then, though, our custom server + client (and I imagine all test clients as well) has been unable to leverage the play.pokemonshowdown.com login server for authentication due to CORS errors.

I imagine this is because CORS header settings weren't transferred over from old login to new login, but I could be totally wrong. Just wanted to check in and see if these were intentional changes on the developers' part? It would help me to manage my own infrastructure for our draft league.

Thanks!

kumarde commented 1 year ago

Ah – I see that the fix was implemented here: https://github.com/smogon/pokemon-showdown-loginserver/commit/52840af23e7880bbf55e7102c31072fe9411df6b

I will just wait for when you deploy the update, then! Cheers!

mia-pi-git commented 1 year ago

Hi! That commit is only a fix for testclients. Clients in production use should instead use OAuth, which is currently being worked on and should be supported soon.

kumarde commented 1 year ago

Understood!

For my own testing purposes, do you happen to know when the CORS update for test clients will be deployed?

Thanks!