smogon / pokemon-showdown-loginserver

MIT License
4 stars 26 forks source link

Fix player name length check in `addreplay` action #23

Closed Karthik99999 closed 9 months ago

Karthik99999 commented 9 months ago

I'm unsure if this is the only issue with side server replays. Currently, if I send 2 player names both with a length of 19, the proper replay id is sent back, but I couldn't see it until I set hidden to 2 (see https://replay.pokemonshowdown.com/dl-gen9paldeadexdraft-1, the battle was originally not private on the server)

Zarel commented 9 months ago

Thanks for the catch! Sadly I haven't had much time to look into what was wrong with side server Replays yet.