smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.72k stars 2.76k forks source link

Fix Slow Start duration on switch in #10262

Closed ChloeNixon closed 2 months ago

ChloeNixon commented 4 months ago

Based on the bug report at https://www.smogon.com/forums/threads/slow-start-turn-count-on-switches.3741527/.

Changed slowstart configuration to not decrement duration during an inactive turn, and made new test cases in slowstart to reflect changes.

DaWoblefet commented 2 months ago

Sorry for taking so long! I merged the tests since they were very similar, but the implementation's good. Technically this wouldn't cover for very niche edge cases with Sky Drop, but we implement it this way for a bunch of other effects that are checking if the Pokemon is just now switching in (e.g. Stakeout) so I'm OK with that minor bug since it's present in a bunch of other cases right now.