smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.74k stars 2.77k forks source link

Add min source gen for event-only Pokemon #10339

Closed dot-Comfey closed 3 months ago

dot-Comfey commented 3 months ago

https://www.smogon.com/forums/threads/shiny-jirachi-validation.3733786/ The validator assumes that the Jirachi is from an event that actually does have HP Fighting; while this assumption isn't wrong, what's wrong is that the validator thinks the Jirachi is from Gen 9 due to move sources having to be from Gen 9. This change makes it so that the minimum source gen of an event-only Pokemon is separately identified when needed.

This also causes a different set to be illegal (https://pokepast.es/2a73208c20ed5503 in Gen 7 OU), which from my understanding should be the intended behavior.

DaWoblefet commented 3 months ago

Thanks dot-Comfey!