smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.64k stars 2.71k forks source link

Improve and simplify Random Battles tests #10366

Closed livid-washed closed 1 week ago

livid-washed commented 1 week ago

For revamped formats, tests ensuring the correct structure of set data files, that every Pokemon (except Ditto and Unown) generates with four moves, and that all moves on all sets are obtainable, have been combined in a single code block in all-gens.js, instead of repeating mostly identical code for every format.

We have identified illegal moves in Gen 3 Random Battle and Gen 9 Baby Random Battle that were previously not caught due to mistakes or omissions with the tests, and modified the sets accordingly. Specifically:

This also removes some old tests for past gens that are no longer necessary or useful due to the revamps.

adrivrie commented 1 week ago

Is there any particular reason the gen 2/3/4 files still exist?

livid-washed commented 1 week ago

Is there any particular reason the gen 2/3/4 files still exist?

No reason. I'm not sure what the standard practice is but I can delete them.

DaWoblefet commented 1 week ago

Looks good to me! Thanks livid washed!