Slayer95
commented
2 weeks ago Anything that wants to add a handler must call a designated method, and that will set a flag which sim/battle.ts checks before looking for handlers.
That was one of the intended purposes of Battle#onEvent(). In my mind, even, Battle could be a subclass of EventEmitter, or very similar, anyway. However, after I got Battle#onEvent() working for unit tests, I deprioritized that plan.
A considerable amount of time is spent in
sim/battle.tsduringnpm run full-test.Profiling
Here are some simple profiling results taken during
npm run full-test, on a branch with #10616 (because that removes most of the randbats time, which makesExhaustiveRunnerstand out).v8 prof
I'm seeing 30-40 seconds worth attributed to
findEventHandlersandfindPokemonEventHandlers(the latter is the bulk of the former) in a v8 prof.ad hoc profiling (performance.now() and counting):
findEventHandlers6.5 million calls 42368 milliseconds Returned handlers length: frequency{ '0': 6152113, '1': 335755, '2': 11933, '3': 188, '4': 10, '9': 1 }94% of the time, no handlers.findPokemonEventHandlers38.5 million calls 37365 milliseconds Returned handlers length: frequency{ '0': 38137046, '1': 348380, '2': 13907, '3': 617, '4': 48, '5': 2 }99% of the time, no handlers.Note: with call counts this high, my caveman profiling has noticeable overhead. I saw +4 seconds in
findEventHandlersand +10 seconds infindPokemonEventHandlers. Nevertheless,findPokemonEventHandlersis a hotspot inExhaustiveRunnerduring tests.My suggestion
It's already ~1 microsecond per call. I don't think that can get radically faster in JS. So, call it less. I think a strategy like
modDatainsim/dex.tscan work here: Anything that wants to add a handler must call a designated method, and that will set a flag whichsim/battle.tschecks before looking for handlers. Conversely, when a handler is removed, the remove method will check if there are any handlers left and update the flag accordingly.Then, during
findEventHandlersandfindPokemonEventHandlers: If the flag is false, there are no handlers, return early. This is the 95-99% case. If the flag is true, there are handlers, run the method as normal.