When a player DCs during team preview, the request details aren't retained.

smogon / pokemon-showdown

Pokémon battle simulator.

https://pokemonshowdown.com

MIT License

4.8k stars 2.8k forks source link

When a player DCs during team preview, the request details aren't retained. #1143

Closed DanUgore closed 10 years ago

DanUgore commented 10 years ago

Causes both players to only pick their leads and not the other members of their team. Relevant to GBU/Battle Spot Metas.

Plan on fixing this when I have an internet connection that doesn't suck.

Slayer95 commented 10 years ago

Fixed in https://github.com/Zarel/Pokemon-Showdown-Client/commit/54fba6e9856914ca406d39d0e30f5cea1f6160d6

DanUgore commented 10 years ago

I don't think we should leave it up to the client to retain the Team Preview count. It's an error on the server's part.

Slayer95 commented 10 years ago

Any server should only send a single team preview request, so those are equivalent solutions. I went straight to the simplest one, but I guess you can still fix the server for a more coherent behaviour.

Zarel commented 10 years ago

No, a server can send arbitrarily many team preview requests. The client should be able to handle any request whether or not it comes up in a regular game.

We should definitely fix the server and revert your client change.

Slayer95 commented 10 years ago

Oh, well ;-;

DanUgore commented 10 years ago

K I'm doing this now o3o

DanUgore commented 10 years ago

Fixed in 39f17f4978d4526a747a15539a151e64cb5c5319