search

smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.65k stars 2.71k forks source link

Seasonals Sleigh Showdown is still bugged #1358

Closed ascriptmaster closed 9 years ago

ascriptmaster commented 9 years ago

Calling @Joimer

http://replay.pokemonshowdown.com/seasonalsleighshowdown-192018585 (Turn 28): Zekrom hits a tree, goes to 0 HP, then tries to Roost, which fails.

http://replay.pokemonshowdown.com/seasonalsleighshowdown-192022880 (Turn 13): Octillery hits a tree, goes to 0 HP, then tries to Rock Blast. Instead of executing the move, it suddenly faints.

http://replay.pokemonshowdown.com/seasonalsleighshowdown-192030265 (Turn 6): Hitting hazards in Seasonals reveals Illusion users.

Slayer95 commented 9 years ago

return false if the pokemon has 0 HP at the end of the onBeforeMove handler Regarding Illusion, we can just say it's a mechanic and call it a day.

ascriptmaster commented 9 years ago

We can probably do like getName or whatever to maintain the Illusion?

Slayer95 commented 9 years ago

Fixed in https://github.com/Zarel/Pokemon-Showdown/commit/67df11748d3a4a43b860a9a8eb447609b3fe276a