search

smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.77k stars 2.79k forks source link

Networking tests are noisy and flaky #3215

Closed Slayer95 closed 7 years ago

Slayer95 commented 7 years ago

See e.g. https://travis-ci.org/Zarel/Pokemon-Showdown/builds/198710235 [Gist]

Zarel commented 7 years ago

Let's disable them?

Morfent commented 7 years ago

I'll make them get skipped until I work out a way to make the workers shut up while the tests are running. I think closing workers' stdout pipes might work. I'll look into why the tests that require IPC for eval are crashing so the crashlogger can shut up as well.

Zarel commented 7 years ago

Fixed in #3235

Morfent commented 7 years ago

It seems like this is related to what version of Node's being run. Using v6.2.2 like Travis was, the messages finally showed up, but I haven't been able to get them to appear on v7.5.0. I'll need to look into what changes have been made between those versions to find out what's causing this.

Zarel commented 7 years ago

That explains it; I was on Node 6.0.0