smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.67k stars 2.72k forks source link

Hidden Power is broken #4026

Open killemall420 opened 6 years ago

killemall420 commented 6 years ago

I don't know if I'm the only one who noticed this, but whenever I put a Hidden Power type on a Pokemon like say, Kyurem-Black with a physical and special attack and then save my team, it drops my IVs to 30, even though I'm on Sun and Moon, not ORAS, BW, etc. It makes it impossible for me to use Pokemon like Mega Diancie correctly and I'm super frustrated no one has fixed this yet.

Some screenshots showing the problem here: glitch part 1 When I give Mega Diancie the moves glitch part 2 Then I save my team glitch part 3 This happens glitch part 4 And Showdown says its just fine

Obviously this isn't just a problem with Mega Diancie, the same problem occured with Greninja as well. 10/10 needs fix P.S. I'm using the app, however I tested this on the browser and the same thing happened there so it's not just a problem with the app.

Zarel commented 6 years ago

I've found a related bug, but I can't reproduce this exact issue.

Can you give step-by-step instructions for what you do to make this happen? Preferably starting from opening an Incognito/Private browser tab and navigating to PS.

LegoFigure11 commented 6 years ago

Tried in an incognito tab, was able to reproduce (Chrome 61.0.3163.100, Windows 10). Steps are as follows:

At this point you can observe that all IVs are listed as 31s

IVs are now changed to 31.30.31.30.31.30

(Vid of replication can be seen at https://youtu.be/SvWgssYWcdo)

Zarel commented 6 years ago

Okay, I've got it, thanks.

killkrazed commented 6 years ago

How is this a bug? It's intentional is it not? This is how the type of hidden power has always been decided on, it's based on the IV's of the pokemon so when adding hidden power of a specific type it must change the IV's to a valid configuration or else the move will be illegal.

The only hidden power that works with 6 perfect IV's is Dark.

AustinXII commented 6 years ago

@killkrazed I don’t believe that’s the case in SuMo

HoeenCoder commented 6 years ago

Bottle caps in sun/moon allow ivs to be boosted to 31 while maintaining the existing HP type, this is because it dosent actually change the IV in game (so it dosent effect HP type or breeding), but simply makes it act as if its 31 in battle. This is implemented on PS by assuming that if an iv is 31, its bottle capped. So a pokemon with 31/31/31/31/31/31 ivs can technically have any HP type.

alchzh commented 6 years ago

close?

HoeenCoder commented 6 years ago

I checked, the issue isn't resolved.

alchzh commented 6 years ago

oh ok, I could have sworn it was fixed by something... :|

Zarel commented 6 years ago

The main problem is that we currently don't save generation in import/export, and we need to know generation for things like this.