use PRNG to roll Pokemon gender

[yuzeh]

Is there a reason that Math.random is being used on this line?

https://github.com/Zarel/Pokemon-Showdown/blob/99d682ca26fb184f10a788bf7c5406dad8e951af/sim/pokemon.js#L119

[Zarel]

No, this should definitely be changed to PRNG.

[yuzeh]

Cool! This is actually where the roll should happen, I believe:

https://github.com/Zarel/Pokemon-Showdown/blob/e8d8a6f/data/random-teams.js#L498

[Zarel]

We support random gender with customized teams. It's actually the default setting.

[Zarel]

See the "Random" setting?

[yuzeh]

Okay, sounds like this should happen at the first callsite then.

[Zarel]

It should be replaceable with this.battle.random()

[yuzeh]

While we're here, I think these calls should also be changed to use the PRNG:

https://github.com/Zarel/Pokemon-Showdown/blob/aae46ffd4669d47cbdf47798ab21120f21f6f98a/sim/side.js#L187

https://github.com/Zarel/Pokemon-Showdown/blob/aae46ffd4669d47cbdf47798ab21120f21f6f98a/sim/battle.js#L489

https://github.com/Zarel/Pokemon-Showdown/blob/aae46ffd4669d47cbdf47798ab21120f21f6f98a/sim/battle.js#L542

https://github.com/Zarel/Pokemon-Showdown/blob/aae46ffd4669d47cbdf47798ab21120f21f6f98a/sim/battle.js#L2417

https://github.com/Zarel/Pokemon-Showdown/blob/aae46ffd4669d47cbdf47798ab21120f21f6f98a/sim/battle.js#L2429

Does this sound right?

[Zarel]

Agreed, there should be no Math.random() in sim/.

[yuzeh]

Fixed in #4365