search

smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.77k stars 2.79k forks source link

Move choices with `ultra` are showing up as `mega` in replay logs #4380

Closed yuzeh closed 6 years ago

yuzeh commented 6 years ago

See:

https://github.com/Zarel/Pokemon-Showdown/blob/9c37960ab645b69ff6ca3e7beddc729221bae8ac/sim/side.js#L449

https://github.com/Zarel/Pokemon-Showdown/blob/9c37960ab645b69ff6ca3e7beddc729221bae8ac/sim/side.js#L126

I'm guessing this behavior is intentional for client compatibility. Are there any plans to make the client recognize ultra?

Zarel commented 6 years ago

Replay logs should honestly not have move choices at all, at least not in the present format. I'll refactor the whole thing sooner or later.

Zarel commented 6 years ago

Fixed; PS no longer has move choices in replay logs. Our replacement is the inputlog, which still appears in replay sources.

yuzeh commented 6 years ago

This is excellent!

When did the changes go live?

Zarel commented 6 years ago

Aug 2, apparently:

https://github.com/Zarel/Pokemon-Showdown/commit/8c6852c72dc49499264629079afc69ca81be9539#diff-8e7de5adf598c3773e176809c74c0217

Slayer95 commented 5 years ago

fwiw, inputLog still had this same issue due to #5294 (fixed in 47111ac).