search

smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.77k stars 2.79k forks source link

Learnsets displayed on teambuilder should be the same as those used for server validation. [Medium priority] #6012

Closed TZubiri closed 4 years ago

TZubiri commented 4 years ago

This encompasses a large amount of inaccuracies presented when selecting moves for pokemon, for example, teambuilder assumes the following incorrectly:

Unless I am missing something, whatever data source validation is using (the one used server side when matchmaking, and the one used client side when clicking the "validate" button in teambuilder) could be used to generate the list of moves to present to the user. If the data source is the same, then I'm not sure what's causing these inaccuracies.

Original User report: https://www.smogon.com/forums/threads/bug-reports-v3-read-original-post-before-posting.3634749/post-8287549 https://www.smogon.com/forums/threads/bug-reports-v3-read-original-post-before-posting.3634749/page-70#post-8286360 Several comments on the OU chat.

TZubiri commented 4 years ago

Related: https://github.com/smogon/pokemon-showdown-client/issues/1399

Perhaps the client and server repos could be merged. A big selling point of using node js is to reuse client and server code.

Zarel commented 4 years ago

Fixed in smogon/pokemon-showdown-client#1403

Zarel commented 4 years ago

Client issue 1399 is entirely unrelated.

Zarel commented 4 years ago

Validators and move lists are necessarily separate. Obviously, the validation code handles egg move validation and event move validation; it's way too powerful/slow for just generating move lists.