smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.74k stars 2.77k forks source link

Level 1 Fully Evolved Pokemon Not Allowed #8180

Open test123 opened 3 years ago

test123 commented 3 years ago

What's the issue?

Level 1 fully evolved Pokemon are considered to be illegal on Pokémon Showdown.

Why should it be legal?

If we transfer a min CP Pokemon over from PokemonGO to PokemonHome, it ends up being level 1. This would make it possible to get Level 1 of any Pokemon, if it meets the following conditions:

This process is explained further in this video: https://www.youtube.com/watch?v=hONErGknIe4.

How to reproduce the error:

Go to the Team Builder, and validate this team for Gen 8 PU.

Aggron  
Ability: Rock Head  
Level: 1  
EVs: 1 HP  
- Head Smash  

You get the message: Aggron must be at least level 42 to be evolved.

Of course, if I am missing something, or this behaviour is not desired on Pokémon Showdown, please do close the issue. :)

SadisticMystic commented 3 years ago

learnsets.ts contains an "encounters" field which documents every every Pokemon that can be met in the wild at a level below either its evolution level, or the level that eggs hatch at in their respective game, up to USUM. I added them a couple years back, but the logic to take that data into account for legality checks was never implemented (except that the placeholder data for evolution levels on species that evolve by means other than level was removed, so now for example the sim will validate a level 1 Bellossom as legal in gen7ou, but you could never get a Gloom at any level below 14 in any game that could feed into that, or 21 by starting from Oddish stage, so that's supposed to be the real bottleneck).

Since then we have Let's Go, Go, and Sw/Sh which were never added to those lists, but pretty much everything that's available from those games can duck under their previous minimum levels due to things like unpowered evolution in Go, or joining another player's 5-star raid with no badges of your own in Sw/Sh (and that's not even assuming we want to canonize the Pomeg-like glitch there that lets you get evolutions from an unhatched egg).

vidyawantstobattle commented 1 year ago

@test123 If @SadisticMystic 's comment provides context for this issue, could you please close it?