smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.82k stars 2.81k forks source link

Unable to use acupressure on ally Pokemon #8589

Open dodopool opened 2 years ago

dodopool commented 2 years ago

Hello!

Replay: https://replay.pokemonshowdown.com/gen8freeforallrandombattle-1481073822

When Shuckle tries to use acupressure on an ally Pokemon (like Pheromosa or Sandslash), I observe the following:

(After selecting acupressure)

  1. Message appears: [Invalid choice], Can't move: Invalid target for Acupressure
  2. The timer stops

(After clicking on cancel)

  1. Message appears: [Invalid choice], There's nothing to cancel
  2. I am asked to select the attack for the upcoming turn

So, it seems like the move has been selected (because the timer has stopped), but it has actually not been selected (because of the error message "[Invalid choice], Can't Move: Invalid target for Acupressure").

So, I think there are two issues to be noted:

  1. Why is Shuckle unable to use acupressure on an ally Pokemon?
  2. Even if battle mechanics do not allow this to happen, the timer should continue running and the user must be asked to select a new attack for the upcoming turn.

Also, do have a look at the two video files attached with this issue. This behavior cannot be seen in the replay because it is happening only to me (and not others).

https://user-images.githubusercontent.com/88382162/147528882-fce97662-6f96-4289-b07f-0c5a9d6df3fc.mp4

https://user-images.githubusercontent.com/88382162/147528896-983e8c75-f043-4a0a-b52c-fd130d1caacd.mp4

DaWoblefet commented 2 years ago

In Free-For-Alls, Acupressure isn't supposed to be able to target an ally. The red [Invalid choice] text indicates the server stopping you from using the attack. The display should not let you actually click the move, which is a client bug.

This is a known client bug: https://github.com/smogon/pokemon-showdown/projects/3#card-69824354