search

smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.64k stars 2.71k forks source link

Protosynthesis doesn't activate after mon with Cloud Nine is switched out #9469

Open Skeli789 opened 1 year ago

Skeli789 commented 1 year ago

If a Pokemon with Protosynthesis uses Sunny Day while another Pokemon with Cloud Nine is on the field, Protosynthesis does not activate. As soon as the Pokemon with Cloud Nine leaves the field the activation message is supposed to print. However, this behaviour is not currently present on Showdown. Video Proof from Scarlet

Luke-Skyguy commented 1 year ago

I checked the code to search what can be the cause of this, it seems that in abilities.ts , where Protosyntesis and Cloud are, and in this line is at the end of Cloud Nine:

suppressWeather:true

I explored both abilities methods and the location of this boolean and i didnt get to any conclusion, i presumpted that the effect of the ability keeps doing the effect on the current Pokemons. It may be not a trigger condition in the Protosyntesis method to surpass this.

If anyone with experience resolves this issue i would be very grateful if it could be explained how the problem was solved, so in the future i could give a hand on this kind of issues.

urkerab commented 1 year ago

This was supposed to have been fixed by #9118 although there's no test to verify that.

akbierly commented 5 months ago

@urkerab @Luke-Skyguy Im still seeing this issue with cloud nine. I originally noticed it with mega altaria losing cloud nine mid turn after m-evolving, then protosynthesis mons would not ever get their boost even after sun went up. I have numerous examples. I also tested with golduck to see if it was just m-altaria but it seems to be all cloud nine users. Can you please open up this bug and fix ASAP. Im running 3 proto users in a draft league and I dont want to be punished for this bug unfairly.

Example 1: Scream tail should get proto boost and outspeed chien pao: https://replay.pokemonshowdown.com/gen9doublescustomgame-2051277320

Example 2: Shiftry with chlorophyll does work, immediately moving before urshifu thanks to its chlorophyll boost, although notably the stadium effects text does not update right away. (Shiftry moves first even though sun is still crossed out at the time) https://replay.pokemonshowdown.com/gen9doublescustomgame-2051279312

Example 3: Same example as 1 but with golduck https://replay.pokemonshowdown.com/gen9doublescustomgame-2051289948