search

smogon / pokemon-showdown

Pokémon battle simulator.
https://pokemonshowdown.com
MIT License
4.67k stars 2.72k forks source link

Combining Diacritical Marks in Species Names (Flabébé) #9569

Open kwsch opened 1 year ago

kwsch commented 1 year ago

Exporting a paste of a Flabébé incorrectly exports text for the Species Name, which will cause issues with other applications that parse outputs from Showdown.

Flabébé (F)  
Ability: Flower Veil  
Level: 50  
Tera Type: Fairy  
- Calm Mind

Showdown is exporting é as e◌́, as shown in the Unicode byte representation below. image

For reference, the official name strings do not use combined diacritics, they use u16:0x00E9=é.

Downstream consumers like pokepast.es do not recognize Showdown's current export format, because they do not expect the need to normalize any strings: https://pokepast.es/666f800df6848fb4 image

DaWoblefet commented 1 year ago

Looks like originally, this was done to preserve Flabébé's id being 'flabebe': https://github.com/smogon/pokemon-showdown/commit/26f5b6ba56d695caf46ca84bc48be4bee00eaa2a

I think it's a good idea to fix this for the reasons Kaphotics mentioned, but also think ID preservation is valuable. We can explore options that fulfill both needs.