Contao 4.9 PHP7.4 compability

Ainschy commented 3 years ago

The extension works fine for contao 4.4, but has some issues in contao 4.9

By installing the extension a warning comes up:

Warning: Ambiguous class resolution, "Contao\ModuleSearch" was found 2x: in "/srv/www/vhosts/XXX/vendor/smohring/cearch-pro-bundle/src/Resources/contao/modules/ModuleSearch.php" and "/srv/www/vhosts/XXX/vendor/contao/core-bundle/src/Resources/contao/modules/ModuleSearch.php", the first will be used. Warning: Ambiguous class resolution, "Contao\Search" was found 2x: in "/srv/www/vhosts/XXX/vendor/smohring/cearch-pro-bundle/src/Resources/contao/classes/Search.php" and "/srv/www/vhosts/XXX/vendor/contao/core-bundle/src/Resources/contao/library/Contao/Search.php", the first will be used.

Found only fallback language sites, no found in other languages
missing context in search results

If i can help, let me know.

Misco commented 2 years ago

Hello,

i was able to modify the ModulSearch.php it is working fine and shows context. Language i could not test:

`<?php

/**

Contao Open Source CMS
Copyright (c) 2005-2015 Leo Feyer
@license LGPL-3.0+ */

namespace Contao;

use Contao\CoreBundle\Exception\PageNotFoundException; use Patchwork\Utf8;

/**

Front end module "search".

@author Leo Feyer https://github.com/leofeyer */ class ModuleSearch extends \Module {

/**

Template
@var string */ protected $strTemplate = 'mod_search';

public static function getMatchVariants(array $arrMatches, string $strText, string $strLocale): array { $iterator = \IntlRuleBasedBreakIterator::createWordInstance($strLocale); $iterator->setText($strText);

// As the search index is shared across all languages, we can not use
// locale specific rules here (like de-ASCII or tr-Lower).
if (\in_array('Latin-ASCII', \Transliterator::listIDs(), true))
{
    $transliterator = \Transliterator::createFromRules('::Latin-ASCII; ::Lower;');
}
else
{
    $transliterator = \Transliterator::create('Lower');
}

$arrMatches = array_map(
    static function ($match) use ($transliterator)
    {
        return $transliterator->transliterate($match);
    },
    $arrMatches
);

$variants = array();

foreach ($iterator->getPartsIterator() as $part)
{
    if ($iterator->getRuleStatus() !== \IntlBreakIterator::WORD_NONE && !\in_array($part, $variants, true) && \in_array($transliterator->transliterate($part), $arrMatches, true))
    {
        $variants[] = $part;
    }
}

return $variants;

}

/**

Display a wildcard in the back end

@return string */ public function generate() { if (TL_MODE == 'BE') { /* @var BackendTemplate|object $objTemplate / $objTemplate = new \BackendTemplate('be_wildcard');

$objTemplate->wildcard = '### ' . Utf8::strtoupper($GLOBALS['TL_LANG']['FMD']['search'][0]) . ' ###';
$objTemplate->title = $this->headline;
$objTemplate->id = $this->id;
$objTemplate->link = $this->name;
$objTemplate->href = 'contao/main.php?do=themes&amp;table=tl_module&amp;act=edit&amp;id=' . $this->id;

return $objTemplate->parse();

}

return parent::generate(); }

/**

Generate the module */ protected function compile() { // Mark the x and y parameter as used (see #4277) if (isset($_GET['x'])) { \Input::get('x'); \Input::get('y'); }

// Trigger the search module from a custom form if (!isset($_GET['keywords']) && \Input::post('FORM_SUBMIT') == 'tl_search') { $_GET['keywords'] = \Input::post('keywords'); $_GET['query_type'] = \Input::post('query_type'); $_GET['per_page'] = \Input::post('per_page'); }

$blnFuzzy = $this->fuzzy; $strQueryType = \Input::get('query_type') ?: $this->queryType;

$strKeywords = trim(\Input::get('keywords'));

$this->Template->uniqueId = $this->id; $this->Template->queryType = $strQueryType; $this->Template->keyword = \StringUtil::specialchars($strKeywords); $this->Template->keywordLabel = $GLOBALS['TL_LANG']['MSC']['keywords']; $this->Template->optionsLabel = $GLOBALS['TL_LANG']['MSC']['options']; $this->Template->search = \StringUtil::specialchars($GLOBALS['TL_LANG']['MSC']['searchLabel']); $this->Template->matchAll = \StringUtil::specialchars($GLOBALS['TL_LANG']['MSC']['matchAll']); $this->Template->matchAny = \StringUtil::specialchars($GLOBALS['TL_LANG']['MSC']['matchAny']); $this->Template->action = ampersand(\Environment::get('indexFreeRequest')); $this->Template->advanced = ($this->searchType == 'advanced');

// Redirect page if ($this->jumpTo && ($objTarget = $this->objModel->getRelated('jumpTo')) instanceof PageModel) { /* @var PageModel $objTarget / $this->Template->action = $objTarget->getFrontendUrl(); }

$this->Template->pagination = ''; $this->Template->results = '';

// Execute the search if there are keywords if ($strKeywords != '' && $strKeywords != '*' && !$this->jumpTo) {

$arrRootpages = (array) deserialize($this->rootPages);

// Reference page
if (count($arrRootpages) > 0) {
    $intRootId = $this->rootPage;
    $arrPages = $this->Database->getChildRecords($arrRootpages, 'tl_page');
    array_unshift($arrPages, $this->rootPage);
}
// Website root
else
{
    /** @var PageModel $objPage */
    global $objPage;

    $intRootId = $objPage->rootId;
    $arrPages = $this->Database->getChildRecords($objPage->rootId, 'tl_page');
}

// HOOK: add custom logic (see #5223)
if (isset($GLOBALS['TL_HOOKS']['customizeSearch']) && is_array($GLOBALS['TL_HOOKS']['customizeSearch']))
{
    foreach ($GLOBALS['TL_HOOKS']['customizeSearch'] as $callback)
    {
        $this->import($callback[0]);
        $this->{$callback[0]}->{$callback[1]}($arrPages, $strKeywords, $strQueryType, $blnFuzzy, $this);
    }
}

// Return if there are no pages
if (!is_array($arrPages) || empty($arrPages))
{
    return;
}

$strCachePath = \StringUtil::stripRootDir(\System::getContainer()->getParameter('kernel.cache_dir'));

$arrResult = null;
$strChecksum = md5($strKeywords . $strQueryType . (is_array($arrRootpages ? implode('', $arrRootpages) : $intRootId)) . $blnFuzzy);
$query_starttime = microtime(true);
$strCacheFile = $strCachePath . '/contao/search/' . $strChecksum . '.json';

// Load the cached result
if (file_exists(TL_ROOT . '/' . $strCacheFile))
{
    $objFile = new \File($strCacheFile);

    if ($objFile->mtime > time() - 1800)
    {
        $arrResult = json_decode($objFile->getContent(), true);
    }
    else
    {
        $objFile->delete();
    }
}

// Cache the result
if ($arrResult === null)
{
    try
    {
        $result = \Search::searchFor($strKeywords, ($strQueryType == 'or'), $arrPages, 0, 0, $blnFuzzy, $this->levensthein, $this->maxDist, $this->search_global);
        $arrResult = isset($result['exact']) ? $result['exact'] = $result['exact']->fetchAllAssoc() : array();
    }
    catch (\Exception $e)
    {
        $this->log('Website search failed: ' . $e->getMessage(), __METHOD__, TL_ERROR);
        $arrResult = array();
    }

    if(! empty($arrResult)) {
        \File::putContent($strCacheFile, json_encode($arrResult));
    }
}

$query_endtime = microtime(true);
$this->Template->moreResults = $result['more'];
unset($result);

// Sort out protected pages
if (\Config::get('indexProtected'))
{
    $this->import('FrontendUser', 'User');

    foreach ($arrResult as $k=>$v)
    {
        if ($v['protected'])
        {
            if (!FE_USER_LOGGED_IN)
            {
                unset($arrResult[$k]);
            }
            else
            {
                $groups = \StringUtil::deserialize($v['groups']);

                if (!is_array($groups) || empty($groups) || !count(array_intersect($groups, $this->User->groups)))
                {
                    unset($arrResult[$k]);
                }
            }
        }
    }

    $arrResult = array_values($arrResult);
}

$count = count($arrResult);

$this->Template->count = $count;
$this->Template->page = null;
$this->Template->keywords = $strKeywords;

// No results
if ($count < 1)
{
    $this->Template->header = sprintf($GLOBALS['TL_LANG']['MSC']['sEmpty'], $strKeywords);
    $this->Template->duration = substr($query_endtime-$query_starttime, 0, 6) . ' ' . $GLOBALS['TL_LANG']['MSC']['seconds'];

    return;
}

$from = 1;
$to = $count;

// Pagination
if ($this->perPage > 0)
{
    $id = 'page_s' . $this->id;
    $page = (\Input::get($id) !== null) ? \Input::get($id) : 1;
    $per_page = \Input::get('per_page') ?: $this->perPage;

    // Do not index or cache the page if the page number is outside the range
    if ($page < 1 || $page > max(ceil($count/$per_page), 1))
    {
        throw new PageNotFoundException('Page not found: ' . \Environment::get('uri'));
    }

    $from = (($page - 1) * $per_page) + 1;
    $to = (($from + $per_page) > $count) ? $count : ($from + $per_page - 1);

    // Pagination menu
    if ($to < $count || $from > 1)
    {
        $objPagination = new \Pagination($count, $per_page, \Config::get('maxPaginationLinks'), $id);
        $this->Template->pagination = $objPagination->generate("\n  ");
    }

    $this->Template->page = $page;
}

$contextLength = 48;
$totalLength = 360;     
$lengths = StringUtil::deserialize($this->contextLength, true);

if ($lengths[0] > 0)
{
    $contextLength = $lengths[0];
}

if ($lengths[1] > 0)
{
    $totalLength = $lengths[1];
}

// Get the results
for ($i=($from-1); $i<$to && $i<$count; $i++)
{
    /** @var FrontendTemplate|object $objTemplate */
    $objTemplate = new FrontendTemplate($this->searchTpl ?: 'search_default');

    $objTemplate->image = $arrResult[$i]['imageUrl'];
    $objTemplate->url = $arrResult[$i]['url'];
    $objTemplate->link = $arrResult[$i]['title'];
    $objTemplate->url = \StringUtil::specialchars(urldecode($arrResult[$i]['url']), true, true);
    $objTemplate->title = \StringUtil::specialchars(\StringUtil::stripInsertTags($arrResult[$i]['title']));
    $objTemplate->class = (($i == ($from - 1)) ? 'first ' : '') . (($i == ($to - 1) || $i == ($count - 1)) ? 'last ' : '') . (($i % 2 == 0) ? 'even' : 'odd');
    $objTemplate->relevance = sprintf($GLOBALS['TL_LANG']['MSC']['relevance'], number_format($arrResult[$i]['relevance'] / $arrResult[0]['relevance'] * 100, 2) . '%');
    $objTemplate->filesize = $arrResult[$i]['filesize'];
    $objTemplate->matches = $arrResult[$i]['matches'];

    $arrContext = array();
    $strText = StringUtil::stripInsertTags($arrResult[$i]['text']);
    $arrMatches = ModuleSearch::getMatchVariants(StringUtil::trimsplit(',', $arrResult[$i]['matches']), $strText, $GLOBALS['TL_LANGUAGE']);

    // Get the context
    foreach ($arrMatches as $strWord)
    {
        $arrChunks = array();
        preg_match_all('/(^|\b.{0,' . $contextLength . '}(?:\PL|\p{Hiragana}|\p{Katakana}|\p{Han}|\p{Myanmar}|\p{Khmer}|\p{Lao}|\p{Thai}|\p{Tibetan}))' . preg_quote($strWord, '/') . '((?:\PL|\p{Hiragana}|\p{Katakana}|\p{Han}|\p{Myanmar}|\p{Khmer}|\p{Lao}|\p{Thai}|\p{Tibetan}).{0,' . $contextLength . '}\b|$)/ui', $strText, $arrChunks);

        foreach ($arrChunks[0] as $strContext)
        {
            $arrContext[] = ' ' . $strContext . ' ';
        }

        // Skip other terms if the total length is already reached
        if (array_sum(array_map('mb_strlen', $arrContext)) >= $totalLength)
        {
            break;
        }
    }

    // Shorten the context and highlight all keywords
    if (!empty($arrContext))
    {
        $objTemplate->context = trim(StringUtil::substrHtml(implode('…', $arrContext), $totalLength));
        $objTemplate->context = preg_replace('/(?<=^|\PL|\p{Hiragana}|\p{Katakana}|\p{Han}|\p{Myanmar}|\p{Khmer}|\p{Lao}|\p{Thai}|\p{Tibetan})(' . implode('|', array_map('preg_quote', $arrMatches)) . ')(?=\PL|\p{Hiragana}|\p{Katakana}|\p{Han}|\p{Myanmar}|\p{Khmer}|\p{Lao}|\p{Thai}|\p{Tibetan}|$)/ui', '<mark class="highlight">$1</mark>', $objTemplate->context);

        $objTemplate->hasContext = true;
    }

    $this->Template->results .= $objTemplate->parse();
}

$this->Template->header = vsprintf($GLOBALS['TL_LANG']['MSC']['sResults'], array($from, $to, $count, $strKeywords));
$this->Template->duration = substr($query_endtime-$query_starttime, 0, 6) . ' ' . $GLOBALS['TL_LANG']['MSC']['seconds'];

} } }`

Misco commented 2 years ago

not sure why code display is not working...

smohring / cearch-pro-bundle

Contao 4.9 PHP7.4 compability #8