smoka7 / multicursors.nvim

A multi cursor plugin for Neovim.
MIT License
492 stars 15 forks source link

feat(hydra): Add dynamic hints and customizable hydra #8

Closed vsedov closed 1 year ago

vsedov commented 1 year ago

Alright, a few changes to the hydra schema.

  1. Add option for borders, and position.
  2. An annoying thing about the hydra hint was that it was randomised. Hence sorting it was the only option i could of think of. The only annoying thing was the last 5 binds put within the layers.
  3. The optional sorting and other means are all optional; you can just remove it if you think its not required.
smoka7 commented 1 year ago

Thanks for the pr it looks good.

smoka7 commented 1 year ago

The only annoying thing was the last 5 binds put within the layers.

why not sort them together?

vsedov commented 1 year ago

The only annoying thing was the last 5 binds put within the layers.

why not sort them together?

The sort, lead to some unreadability,

image

pretty much having the last 5, would let it be slightly more organized id say.

The sort kept, putting the mode changes some where in the middle, which really didn't align well, although if you don't think its needed, we can just get rid of it completely.

smoka7 commented 1 year ago

The sort, lead to some unreadability

The thing is now they're hard coded at the end, but I'm gonna put those with rest of them later. maybe we could put exit heads at the start if opts.exit is set. If you don't wanna deal with this it's ok I'll modify it later, just fix the columns.

vsedov commented 1 year ago

Yeah alright il go ahead and see if i can fix the columns then, cheers.

vsedov commented 1 year ago

Quick changes here, two ways i thought about it was the following

  1. Optional columns based from user input 1-9 column limit.
  2. Or just use width and let vim.api.nvim_win_get_width handle the rest.

Feel free to remove or change it up, if you dont see the need for one or the other.

image

Using width :

image

I gave a shot trying to get alignment with with "width" but couldn't get it working, came close to it though .

smoka7 commented 1 year ago

I kinda merged those two into one thing, see if its okay and I'll merge it later.

vsedov commented 1 year ago

Yeah I see what you did here, I don't think theirs much else to add here.

smoka7 commented 1 year ago

Thank you for all the work you've done here.