search

smoketurner / serverless-vpc-plugin

Serverless Plugin to create a VPC
MIT License
88 stars 35 forks source link

Provide option for using non-deprecated amazon instances with fck-nat #1195

Closed mwillbanks closed 9 months ago

mwillbanks commented 11 months ago

fck-nat provides the same behavior as the amazon nat instances, with the exception that it is up to date and can be run on the arm64 platforms thus reducing overall cost. since several people already have the existing deployed, it makes more sense to provide an option to allow them to use it.

When using createNatInstance = true AND createNatInstanceFckNat = true, this will then utilize the FckNat instances rather than the deprecated amazon instances.

jplock commented 11 months ago

What do you think about making this the default to replace the amazon-managed AMI?

mwillbanks commented 11 months ago

@jplock i think it's the right idea, my only concern was those that already have one running and swapping instance types could create some temporary downtime for them, therefore I thought it would be best not to touch it and instead add an additional option....

I actually had started thinking about extending the option support as well to make the entirety of the nat interface configurable since you can actually run the fck-nat on different instance types as well (but thats for another time).

jplock commented 9 months ago

I'm going to close this PR. Thank you for the contribution. I'm going to archive this repo as I no longer use this plugin.