search

smoketurner / serverless-vpc-plugin

Serverless Plugin to create a VPC
MIT License
88 stars 35 forks source link

enabled: false doesn't disable the plugin #666

Closed tareqtms closed 3 years ago

tareqtms commented 3 years ago

I am trying to disable the plugin for some stages by providing enabled: false (keeping the other parameters same. ). But it's still generating VPC and subnets when I run serverless deploy. I also tried hardcoding the value like this: (just making sure, I am not doing something wrong while doing it conditionally)

  vpcConfig:
    # Whether plugin is enabled. Can be used to selectively disable plugin
    # on certain stages or configurations. Defaults to true.
    enabled: false

    cidrBlock: '10.0.0.0/16'
.....
tareqtms commented 3 years ago

@jplock As I see the code and commits, the enabled option was added with the commit on April 30, but the latest release of this package was on Jan 18, I think we just need a new release for a fix on this. Can you please create a new release?

jplock commented 3 years ago

Sorry been occupied with work, I’ll try and take care of this next week

tareqtms commented 3 years ago

Thanks

On 26 Jul, 2021, at 8:06 PM, Justin Plock @.***> wrote:

Sorry been occupied with work, I’ll try and take care of this next week

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/smoketurner/serverless-vpc-plugin/issues/666#issuecomment-886733670, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABII5HL4PJAEASB2JJ6Y7ZTTZVTU5ANCNFSM5ACBFPIA.

jplock commented 3 years ago

I just published v1.0.4 that should contain this fix