smokku / pebble

Unofficial Pebble watch support for SailfishOS/Jolla
GNU General Public License v3.0
70 stars 17 forks source link

No notifications when more then one email arrives at a time #16

Closed awlx closed 10 years ago

awlx commented 10 years ago

Hi,

today I noticed that I get no new email notifications when more then one mail is received at a time. Only the phone vibrates and says "2 new messages" but pebble does nothing.

Cheers.

smurfy commented 10 years ago

noticed that too today. i'm looking in to it.

locusf commented 10 years ago

I guess this is due to how lipstick handles notifications of emails (or rather Jolla notification model) as it updates the same notification for email if there is one unread.

awlx commented 10 years ago

But it even occurs when it receives two emails at a time. And not only when there is already one notification. I expected to get at least the first notification when two mails arrive at a time.

smurfy commented 10 years ago

Ok i think i found the problem.

Email notifications gets only sent if both "data" and "subject" is present in the dbus message. With the combining feature of the notifications in sailfish only on of the fields are filled "2 new emails" (author is empty). so the code does not display the message.

I will fix that, tonight.

Also its planned but i did not do the research for it, to automatically mark the notification read on the phone if successfully sent to the pebble (clear the specific notifications)

awlx commented 10 years ago

Also its planned but i did not do the research for it, to automatically mark the notification read on the phone if successfully sent to the pebble (clear the specific notifications).

That sounds great :). And cool that you found the issue. :+1:

smurfy commented 10 years ago

Problem is, that as before, you only get the notification "2 new emails" no details about the email. I hope the autoclear option will help with that once implemented.

awlx commented 10 years ago

But it's better to get only "2 new emails" instead of nothing :).

awlx commented 10 years ago

org.freedesktop.Notifications /org/freedesktop/Notifications org.freedesktop.Notifications.CloseNotification(uid)

should close the notification when triggered I am going to test it.

smurfy commented 10 years ago

If you implement it, please make sure its an optional feature.

awlx commented 10 years ago

Ok, it does not make much sense to just dismiss the notifications after being sent to pebble because the email client still does only send "1 new email" if it has an unread mail. Maybe there is a way to reset this count but I don't think this is a good idea.

smokku commented 10 years ago

mark the notification read on the phone if successfully sent to the pebble

emphasis :-)

smokku commented 10 years ago

Also, we may revisit the idea to treat notifications as a trigger only, not as a data-source and use dedicated interfaces for messages and emails to pull data from.

awlx commented 10 years ago

Sounds better because at the moment the notifications interface is not that reliable.

mark the notification read on the phone if successfully sent to the pebble emphasis :-)

Sure but I do not find a way to mark the mail read and not only to dismiss the notification after sending it to pebble.

smurfy commented 10 years ago

hmpf. latest log4qt changes and i can't compile it anymore? how to install log4qt to the mer build vm?

smokku commented 10 years ago

log4qt is available at chum: http://repo.merproject.org/obs/sailfishos:/chum:/1.0.8.19:/testing/1.0.8.19_armv7hl/

smurfy commented 10 years ago

I guess i'm to stupid for it :)

I added the chum repo in my mer build vm but i cant install log4qt (it does not find it) also i can't install the rpms manually.

i guess thats because they are for armv7h1 instead of i486 (of which the system in the vm runs).

Can you please describe how to install log4qt in the build vm? (the target)

smokku commented 10 years ago
smoku@wing:~$ ssh -p 2222 -i ~/SailfishSDK/vmshare/ssh/private_keys/engine/mersdk mersdk@localhost
[mersdk@SailfishSDK ~]$ sb2 -t SailfishOS-armv7hl -m sdk-install -R zypper ar http://repo.merproject.org/obs/sailfishos:/chum:/1.0.8.19:/testing/1.0.8.19_armv7hl/sailfishos:chum:1.0.8.19:testing.repo

Then set gpgcheck=0 in /etc/zypp/repos.d/sailfishos:chum:1.0.8.19:testing.repo, go to Qt Creator, Sailfish tab, refresh SailfishOS-armv7hl packages and install log4qt-devel.

smurfy commented 10 years ago

thanks, there was no /etc/zypp... file but providing the -G param

sb2 -t SailfishOS-armv7hl -m sdk-install -R zypper ar -G http://repo.merproject.org/obs/sailfishos:/chum:/1.0.8.19:/testing/1.0.8.19_armv7hl/sailfishos:chum:1.0.8.19:testing.repo

worked too.

Also it still did not compile because it seams there is another dependency on "libicu-devel" too.

I will test my fix over the next 16 hours or so and do a pull request tomorrow.

smokku commented 10 years ago

ICU is provided by default in standard repos.

eras commented 9 years ago

Has this issue been really resolved (bug closed)? I'm still receiving 'x new mails' notifications on my Pebble unless I clear them from Jolla's notification view. I have pebble-0.15-1.armv7hl. Or did the latest Jolla firmware update break this..

smokku commented 9 years ago

@eras This issue is about not getting notifications about new mail at all on the watch, not about the content. If you want to talk about getting the content of new messages instead of "2 new messages", you can open another issue, as it is not as straightforward as it seems and may need additional discussion.

smokku commented 9 years ago

sic https://openrepos.net/comment/5308#comment-5308