search

smol-rs / async-broadcast

Async broadcast channels
Apache License 2.0
151 stars 26 forks source link

Bump to event-listener v3.0.0 #43

Closed notgull closed 9 months ago

notgull commented 1 year ago

Testing to make sure that event-listener v3.0.0 actually works before we release smol-rs/event-listener#58

notgull commented 11 months ago

@zeenix Are you fine with a breaking change? If so I can make Send and Recv !Unpin, which would allow us to not need to box the EventListener and save a heap allocation.

zeenix commented 11 months ago

@zeenix Are you fine with a breaking change?

Yes. I'm breaking API in my using crate (zbus) anyway. :)

If so I can make Send and Recv !Unpin, which would allow us to not need to box the EventListener and save a heap allocation.

That would be nice but I suspect a lot of users will want them to be Unpin. Can we provide API to created Pin<Box<..>> to make the transition easier?

notgull commented 9 months ago

@zeenix Any chance you can review this?