search

smol-rs / async-broadcast

Async broadcast channels
Apache License 2.0
163 stars 26 forks source link

Port to event-listener v5.0 #48

Closed notgull closed 7 months ago

notgull commented 9 months ago

Also Make Send and Recv !Unpin to allow for future optimizations (API break).

cc smol-rs/event-listener#105

zeenix commented 8 months ago

@notgull some unanswered questions here before we could merge this.

zeenix commented 8 months ago

Oh and it needs a rebase.

zeenix commented 8 months ago

All good. Only thing is that if async-channels's Sender/Receiver are turning !Unpin, so should the Sender/Receiver here, to keep a consistent behavior across smol?

notgull commented 8 months ago

Sure, if you're fine with the API break.

zeenix commented 8 months ago

Sure, if you're fine with the API break.

Sure, assuming there is a good chance the performance benefits that async-channel is expected to gain from this change, will also apply here.