search

smol-rs / async-broadcast

Async broadcast channels
Apache License 2.0
151 stars 26 forks source link

adding `no_std` support #59

Closed dscso closed 4 weeks ago

dscso commented 2 months ago

It seams to pass all tests locally and also runs on the ESP32 as far as I see. it seams to address #50 as well. I am not that familiar with wasm though.

Fixes #58.

zeenix commented 2 months ago

It seams to pass all tests locally and also runs on the ESP32 as far as I see. it seams to address #50 as well.

Nice! Thanks for this PR. I'm sorry I didn't get to review it yet. I just started a new job so a bit busy with that. :) I'll try to have a look soon.

dscso commented 2 months ago

Cool! Thanks for the clarification and no worries there is no need to rush. I hope you can also use Rust in your Job :D

zeenix commented 2 months ago

Cool! Thanks for the clarification and no worries there is no need to rush. I hope you can also use Rust in your Job :D

I wouldn't take the job, otherwise. :)

zeenix commented 1 month ago

@dscso Ping. Do you think you can finish this soon? We're hoping to do a 1.0 soon and it'd be great to have this done before that.

dscso commented 4 weeks ago

I'd like to avoid using spinlocks in concurrent code.

I also think spinlocks are not the way to solve the issue. In my setting I was using the library in a single processor no interrupt setting, and there spin locks would be valid a solution.

I don't have the resources to implement a complete and clean no_std version without spinlocks.

zeenix commented 4 weeks ago

I don't have the resources to implement a complete and clean no_std version without spinlocks.

Fair enough. Thanks so much for your efforts here, still! I learnt a lot from the PR so it was useful even it it didn't get merged. :+1: