Update tokio to 1 - Githubissues

smol-rs / async-compat

Compatibility adapter between tokio and futures

Apache License 2.0

156 stars 12 forks source link

Update tokio to 1 #6

Closed taiki-e closed 3 years ago

taiki-e commented 3 years ago

Closes #4

Note:

this is a breaking change
this drops support for tokio 0.2/0.3
~~ecosystem is still using tokio 0.2, so some examples are currently disabled~~

taiki-e commented 3 years ago

this drops support for tokio 0.2/0.3

An alternative to this is to use feature flags to support older tokio. I have no strong opinion as to which one to adopt. (Does anyone have an opinion on this?)

ghost commented 3 years ago

I think it's fine to support only tokio 1.0. Soon everyone will be using it.

joshtriplett commented 3 years ago

I think it makes sense for the current version of async-compat to only support tokio 1.0, as long as it makes a non-semver-compatible version bump in the process. That way, if people need to use a package that still depends on tokio 0.2, they can just use an older version of async-compat.

taiki-e commented 3 years ago

It's been about a month since I created this PR, and no one seems to oppose not supporting older versions. (And I think @joshtriplett's opinion makes a lot of sense)

@stjepang Could you review this? (A new version of warp has been released, and the last blocker has also been unblocked.)

taiki-e commented 3 years ago

@stjepang Thanks for the review. I'll merge this and prepare for a new release.

taiki-e commented 3 years ago

Published in v0.2.0