Closed notgull closed 1 year ago
Hmm, considering that concurrent-queue is not used as a public dependency of other smol-rs crates, I think a new breaking release itself is fine...
If the breaking change isn't an issue, then there's no real reason to merge this.
22 introduced a breaking change because, under
no-default-features
,ConcurrentQueue<T>
no longer implementedUnwindSafe
because it was exclusive tolibstd
prior to 1.56. This PR addsautocfg
to detect whether or not we are running in Rust 1.56. If we are, it usesUnwindSafe
fromlibcore
. Otherwise, disabling thestd
feature has no effect.My only concern is that this PR may introduce a footgun for users of old compilers.