v2.0.0 - Githubissues

smol-rs / concurrent-queue

Concurrent multi-producer multi-consumer queue

Apache License 2.0

254 stars 21 forks source link

v2.0.0 #29

Closed notgull closed 1 year ago

notgull commented 1 year ago

Changes:

Add support for the the portable_atomic and loom crates. (#27)
Breaking: Add an std feature that can be disabled to use this crate on no_std platforms. (#22)
Replace usage of cache-padded with crossbeam-utils. (#26)

fogti commented 1 year ago

"adding an std feature" is only a breaking change because crates can opt to default-features = false, right?

notgull commented 1 year ago

"adding an std feature" is only a breaking change because crates can opt to default-features = false, right?

Yes. With the std feature, certain traits that are normally implemented on concurrent-queue are disabled. There is a way around it (see #29), but it's probably better to just go with the breaking change.

fogti commented 1 year ago

I'm not sure if we should release a new version yet, or check if downstream crates might need some additional modifications...

notgull commented 1 year ago

All of smol's crates do not use concurrent-queue as a public dependency. smol is by and large the largest user of concurrent-queue; all of its crates have about 10 million downloads, while the next largest consumer (jackiechan) has about 50k downloads. Of the crates with more than 10k downloads:

jackiechain and barrage are unmaintained forks of async-channel with an alternate version of smol-rs/async-channel#47 implemented.
sosistab imports concurrent-queue but never uses it.

None of these crates have concurrent-queue as a public dependency. Every other crate involved has less than 10k downloads.

notgull commented 1 year ago

@smol-rs/admins It looks like I don't have push permissions, so the release didn't take. Does anyone mind making the push?

taiki-e commented 1 year ago

Published. Thanks for working on this!

(In the future I would like to set up CI to publish the crate via tag push like my crates.)