v2.5.0 - Githubissues

smol-rs / concurrent-queue

Concurrent multi-producer multi-consumer queue

Apache License 2.0

254 stars 22 forks source link

v2.5.0 #66

Closed notgull closed 5 months ago

notgull commented 6 months ago

Add a force_push method that can be used to add an element to the queue by displacing another. (#58)
Make ConcurrentQueue::unbounded() into a const function. (#67)
Fix a compilation error in the Loom implementation. (#65)

notgull commented 6 months ago

Added #67 to this

taiki-e commented 6 months ago

(I don't have time right now and will review the actual changes next weekend.)

notgull commented 6 months ago

Thank you @taiki-e! I appreciate your insight!

(I don't have time right now and will review the actual changes next weekend.)

Would replacing concurrent-queue's implementation with one based on crossbeam-queue be appreciated from this perspective? This way there's only one queue implementation to review.

cc #50

taiki-e commented 6 months ago

(reviewed https://github.com/smol-rs/concurrent-queue/pull/58#pullrequestreview-2014644187)

Would replacing concurrent-queue's implementation with one based on crossbeam-queue be appreciated from this perspective? This way there's only one queue implementation to review.

Yeah, I would like to eventually merge them...