search

smol-rs / futures-lite

Futures, streams, and async I/O combinators.
Apache License 2.0
427 stars 25 forks source link

Re-export `pending` from `std` rather than redefining it #55

Closed joshtriplett closed 1 year ago

joshtriplett commented 2 years ago

This avoids having two versions of pending in programs that use both futures_lite and the version from std.

taiki-e commented 2 years ago

Thanks for the PR. Unfortunately, if the user implements the same trait on both types, this is a breaking change.

(https://github.com/smol-rs/futures-lite/issues/35 is an issue to track this change.)

fogti commented 1 year ago

Given that this is a breaking change anyways, it doesn't really make sense to merge this because the user would need to manually fix their code anyways (given a corresponding bump of the crate version). So I'd reject this PR.

notgull commented 1 year ago

Given that this is a breaking change anyways, it doesn't really make sense to merge this because the user would need to manually fix their code anyways (given a corresponding bump of the crate version). So I'd reject this PR.

I'd agree with rejection.