search

smol-rs / polling

Portable interface to epoll, kqueue, event ports, and wepoll
Apache License 2.0
551 stars 68 forks source link

Remove the std default feature #147

Closed notgull closed 1 year ago

notgull commented 1 year ago

Added in 272bb11eafd22c063bc2e7825070c21443a8fc78 for reasons that are unclear to me. It serves no purpose aside from disabling the API of the entire crate, so it's best to remove it.

fogti commented 1 year ago

what about the CI change in the original commit? (I checked now, it's no longer present)

notgull commented 1 year ago

what about the CI change in the original commit? (I checked now, it's no longer present)

Looks like it was removed in https://github.com/smol-rs/polling/commit/dec94cb423489e2eec27295fcb89f285a380536b when taiki-e was cleaning up the CI configuration

taiki-e commented 1 year ago

This was necessary to add no-std support without requiring a breaking change. (https://github.com/crossbeam-rs/crossbeam/pull/508#issuecomment-631458481 has a more detailed explanation of this.)

However, given that we have decided not to do https://github.com/smol-rs/polling/issues/87, that may no longer be necessary.

what about the CI change in the original commit? (I checked now, it's no longer present)

Looks like it was removed in dec94cb when taiki-e was cleaning up the CI configuration

That check was not just removed, but replaced with a more robust cargo hack build --feature-powerset --no-dev-deps.